Commit fe665816 authored by Pali Rohár's avatar Pali Rohár Committed by Bjorn Helgaas
Browse files

PCI: iproc: Set all 24 bits of PCI class code 

Register 0x43c in its low 24 bits contains PCI class code.

Update code to set all 24 bits of PCI class code and not only upper 16 bits
of PCI class code.

Use a new macro PCI_CLASS_BRIDGE_PCI_NORMAL which represents whole 24 bits
of normal PCI bridge class.

Link: https://lore.kernel.org/r/20220214114109.26809-2-pali@kernel.org


Signed-off-by: default avatarPali Rohár <pali@kernel.org>
Signed-off-by: default avatarBjorn Helgaas <bhelgaas@google.com>
Acked-by: default avatarRoman Bacik <roman.bacik@broadcom.com>
Acked-by: default avatarRay Jui <ray.jui@broadcom.com>
parent 904b10fb

drivers/pci/controller/pcie-iproc.c

+4 −5
Original line number Diff line number Diff line
@@ -789,14 +789,13 @@ static int iproc_pcie_check_link(struct iproc_pcie *pcie) 
		return -EFAULT;

	}



	/* force class to PCI_CLASS_BRIDGE_PCI (0x0604) */

	/* force class to PCI_CLASS_BRIDGE_PCI_NORMAL (0x060400) */

#define PCI_BRIDGE_CTRL_REG_OFFSET	0x43c

#define PCI_CLASS_BRIDGE_MASK		0xffff00

#define PCI_CLASS_BRIDGE_SHIFT		8

#define PCI_BRIDGE_CTRL_REG_CLASS_MASK	0xffffff

	iproc_pci_raw_config_read32(pcie, 0, PCI_BRIDGE_CTRL_REG_OFFSET,

				    4, &class);

	class &= ~PCI_CLASS_BRIDGE_MASK;

	class |= (PCI_CLASS_BRIDGE_PCI << PCI_CLASS_BRIDGE_SHIFT);

	class &= ~PCI_BRIDGE_CTRL_REG_CLASS_MASK;

	class |= PCI_CLASS_BRIDGE_PCI_NORMAL;

	iproc_pci_raw_config_write32(pcie, 0, PCI_BRIDGE_CTRL_REG_OFFSET,

				     4, class);