Commit feaa4a09 authored Nov 22, 2021 by Arnd Bergmann Committed by Vinod Koul Dec 17, 2021

spi: pic32: stop setting dma_config->slave_id



Setting slave_id makes no sense with DT based probing, and
should eventually get removed entirely. Address this driver
by no longer setting the field here.

I could not find which DMA driver is used on PIC32, if it's
in the tree at all, but none of the obvious ones even care
about slave_id any more.

Acked-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Link: https://lore.kernel.org/r/20211122222203.4103644-4-arnd@kernel.org


Signed-off-by: Vinod Koul <vkoul@kernel.org>

parent bdecfcef

drivers/spi/spi-pic32.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -370,7 +370,6 @@ static int pic32_spi_dma_config(struct pic32_spi *pic32s, u32 dma_width)
		cfg.src_addr_width = dma_width;
		cfg.dst_addr_width = dma_width;
		/* tx channel */
		cfg.slave_id = pic32s->tx_irq;
		cfg.direction = DMA_MEM_TO_DEV;
		ret = dmaengine_slave_config(master->dma_tx, &cfg);
		if (ret) {
		@@ -378,7 +377,6 @@ static int pic32_spi_dma_config(struct pic32_spi *pic32s, u32 dma_width)
		return ret;
		}
		/* rx channel */
		cfg.slave_id = pic32s->rx_irq;
		cfg.direction = DMA_DEV_TO_MEM;
		ret = dmaengine_slave_config(master->dma_rx, &cfg);
		if (ret)