Commit ff2293ea authored by Jonathan Cameron's avatar Jonathan Cameron
Browse files

iio:adc:sun4i-gpadc: Use new IRQF_NO_AUTOEN flag instead of request then disable 



This new flag ensures a requested irq is not autoenabled, thus removing
the need for the disable_irq() that follows and closing off any chance
of spurious interrupts.

Signed-off-by: default avatarJonathan Cameron <Jonathan.Cameron@huawei.com>
Cc: Maxime Ripard <maxime.ripard@bootlin.com>
Reviewed-by: default avatarBarry Song <song.bao.hua@hisilicon.com>
Reviewed-by: default avatarAndy Shevchenko <andy.shevchenko@gmail.com>
Reviewed-by: default avatarLars-Peter Clausen <lars@metafoo.de>
Link: https://lore.kernel.org/r/20210402184544.488862-5-jic23@kernel.org
parent aef3ef16

drivers/iio/adc/sun4i-gpadc-iio.c

+2 −2
Original line number Diff line number Diff line
@@ -470,7 +470,8 @@ static int sun4i_irq_init(struct platform_device *pdev, const char *name, 
	}



	*irq = ret;

	ret = devm_request_any_context_irq(&pdev->dev, *irq, handler, 0,

	ret = devm_request_any_context_irq(&pdev->dev, *irq, handler,

					   IRQF_NO_AUTOEN,

					   devname, info);

	if (ret < 0) {

		dev_err(&pdev->dev, "could not request %s interrupt: %d\n",
@@ -478,7 +479,6 @@ static int sun4i_irq_init(struct platform_device *pdev, const char *name, 
		return ret;

	}



	disable_irq(*irq);

	atomic_set(atomic, 0);



	return 0;