Commit 02339374 authored by Dan Carpenter's avatar Dan Carpenter Committed by Greg Kroah-Hartman
Browse files

Staging: bcm: remove unneeded NULL check 



The error handling here is wrong.  If psIntfAdapter were NULL then we
would have a NULL dereference in the debug output on the error path.
But this function is only called from usbbcm_device_probe() when
psIntfAdapter is non-NULL.

Since the check isn't needed and I removed it instead of fixing it.

Signed-off-by: default avatarDan Carpenter <error27@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@suse.de>
parent ef5d2056

drivers/staging/bcm/InterfaceInit.c

+0 −5
Original line number Diff line number Diff line
@@ -529,11 +529,6 @@ INT InterfaceAdapterInit(PS_INTERFACE_ADAPTER psIntfAdapter) 
	BOOLEAN bBcm16 = FALSE;

	UINT uiData = 0;



	if(psIntfAdapter == NULL)

	{

		BCM_DEBUG_PRINT(psIntfAdapter->psAdapter,DBG_TYPE_INITEXIT, DRV_ENTRY, DBG_LVL_ALL, "Interface Adapter is NULL");

		return -EINVAL;

	}

	/* Store the usb dev into interface adapter */

	psIntfAdapter->udev = usb_get_dev(interface_to_usbdev(

								psIntfAdapter->interface));