Commit 040b8648 authored by Jiri Slaby's avatar Jiri Slaby Committed by Mauro Carvalho Chehab
Browse files

media: atomisp: do not free kmalloc memory by vfree 

fw_minibuffer[i].buffer is allocated by kmalloc in sh_css_load_blob_info
and by vmalloc in setup_binary. So use kvfree to decide which of those
allocators to use for freeing.

Also remove the useless cast.

Link: https://lore.kernel.org/linux-media/20210219101216.28406-1-jslaby@suse.cz


Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 184fc42a

drivers/staging/media/atomisp/pci/sh_css_firmware.c

+1 −1
Original line number Diff line number Diff line
@@ -366,7 +366,7 @@ void sh_css_unload_firmware(void) 
			if (fw_minibuffer[i].name)

				kfree((void *)fw_minibuffer[i].name);

			if (fw_minibuffer[i].buffer)

				vfree((void *)fw_minibuffer[i].buffer);

				kvfree(fw_minibuffer[i].buffer);

		}

		kfree(fw_minibuffer);

		fw_minibuffer = NULL;