Skip to content
Unverified Commit 0d7993b2 authored by Mirko Vogt's avatar Mirko Vogt Committed by Mark Brown
Browse files

spi: spi-sun6i: Fix chipselect/clock bug



The current sun6i SPI implementation initializes the transfer too early,
resulting in SCK going high before the transfer. When using an additional
(gpio) chipselect with sun6i, the chipselect is asserted at a time when
clock is high, making the SPI transfer fail.

This is due to SUN6I_GBL_CTL_BUS_ENABLE being written into
SUN6I_GBL_CTL_REG at an early stage. Moving that to the transfer
function, hence, right before the transfer starts, mitigates that
problem.

Fixes: 3558fe90 (spi: sunxi: Add Allwinner A31 SPI controller driver)
Signed-off-by: default avatarMirko Vogt <mirko-dev|linux@nanl.de>
Signed-off-by: default avatarRalf Schlatterbeck <rsc@runtux.com>
Link: https://lore.kernel.org/r/20210614144507.y3udezjfbko7eavv@runtux.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent f422316c
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment