Commit 0fa5b08c authored by Johannes Thumshirn's avatar Johannes Thumshirn Committed by Jens Axboe
Browse files

zonefs: use __bio_add_page for adding single page to bio 



The zonefs superblock reading code uses bio_add_page() to add a page to a
newly created bio. bio_add_page() can fail, but the return value is
never checked.

Use __bio_add_page() as adding a single page to a newly created bio is
guaranteed to succeed.

This brings us a step closer to marking bio_add_page() as __must_check.

Acked-by: default avatarDamien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Signed-off-by: default avatarJohannes Thumshirn <johannes.thumshirn@wdc.com>
Link: https://lore.kernel.org/r/04c9978ccaa0fc9871cd4248356638d98daccf0c.1685532726.git.johannes.thumshirn@wdc.com


Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent effa7dde

fs/zonefs/super.c

+1 −1
Original line number Diff line number Diff line
@@ -1128,7 +1128,7 @@ static int zonefs_read_super(struct super_block *sb) 


	bio_init(&bio, sb->s_bdev, &bio_vec, 1, REQ_OP_READ);

	bio.bi_iter.bi_sector = 0;

	bio_add_page(&bio, page, PAGE_SIZE, 0);

	__bio_add_page(&bio, page, PAGE_SIZE, 0);



	ret = submit_bio_wait(&bio);

	if (ret)