Commit 101703ca authored by Wolfram Sang's avatar Wolfram Sang Committed by Wolfram Sang
Browse files

i2c: mxs: : use proper DMAENGINE API for termination 



dmaengine_terminate_all() is deprecated in favor of explicitly saying if
it should be sync or async. Here, we want dmaengine_terminate_sync()
because there is no other synchronization code in the driver to handle
an async case.

Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Signed-off-by: default avatarWolfram Sang <wsa@kernel.org>
parent 73a370cf

drivers/i2c/busses/i2c-mxs.c

+2 −2
Original line number Diff line number Diff line
@@ -290,14 +290,14 @@ static int mxs_i2c_dma_setup_xfer(struct i2c_adapter *adap, 
select_init_dma_fail:

	dma_unmap_sg(i2c->dev, &i2c->sg_io[0], 1, DMA_TO_DEVICE);

select_init_pio_fail:

	dmaengine_terminate_all(i2c->dmach);

	dmaengine_terminate_sync(i2c->dmach);

	return -EINVAL;



/* Write failpath. */

write_init_dma_fail:

	dma_unmap_sg(i2c->dev, i2c->sg_io, 2, DMA_TO_DEVICE);

write_init_pio_fail:

	dmaengine_terminate_all(i2c->dmach);

	dmaengine_terminate_sync(i2c->dmach);

	return -EINVAL;

}