Commit 153c9a02 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Guenter Roeck
Browse files

hwmon: (hp-wmi-sensors) fix debugfs check 



Checking for Kconfig symbols with #if is wrong:

drivers/hwmon/hp-wmi-sensors.c:1141:5: error: "CONFIG_DEBUG_FS" is not defined, evaluates to 0 [-Werror=undef]

This could be an #ifdef, but an IS_ENABLED() check is even better to
give the best compile coverage.

Fixes: 23902f98 ("hwmon: add HP WMI Sensors driver")
Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Acked-by: default avatarJames Seo <james@equiv.tech>
Link: https://lore.kernel.org/r/20230601213216.3220550-1-arnd@kernel.org


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 23902f98

drivers/hwmon/hp-wmi-sensors.c

+2 −13
Original line number Diff line number Diff line
@@ -1138,8 +1138,6 @@ static int hp_wmi_update_info(struct hp_wmi_sensors *state, 
	return ret;

}



#if CONFIG_DEBUG_FS



static int basic_string_show(struct seq_file *seqf, void *ignored)

{

	const char *str = seqf->private;
@@ -1341,16 +1339,6 @@ static void hp_wmi_debugfs_init(struct device *dev, struct hp_wmi_info *info, 
	}

}



#else



static void hp_wmi_debugfs_init(struct device *dev, struct hp_wmi_info *info,

				struct hp_wmi_platform_events *pevents,

				u8 icount, u8 pcount, bool is_new)

{

}



#endif



static umode_t hp_wmi_hwmon_is_visible(const void *drvdata,

				       enum hwmon_sensor_types type,

				       u32 attr, int channel)
@@ -1959,6 +1947,7 @@ static int hp_wmi_sensors_init(struct hp_wmi_sensors *state) 
	if (err)

		return err;



	if (IS_ENABLED(CONFIG_DEBUG_FS))

		hp_wmi_debugfs_init(dev, info, pevents, icount, pcount, is_new);



	if (!count)