Commit 27cd4978 authored by Ye Bin's avatar Ye Bin Committed by Theodore Ts'o
Browse files

ext4: update 'state->fc_regions_size' after successful memory allocation 



To avoid to 'state->fc_regions_size' mismatch with 'state->fc_regions'
when fail to reallocate 'fc_reqions',only update 'state->fc_regions_size'
after 'state->fc_regions' is allocated successfully.

Cc: stable@kernel.org
Signed-off-by: default avatarYe Bin <yebin10@huawei.com>
Reviewed-by: default avatarJan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220921064040.3693255-4-yebin10@huawei.com


Signed-off-by: default avatarTheodore Ts'o <tytso@mit.edu>
parent 7069d105

fs/ext4/fast_commit.c

+5 −4
Original line number Original line Diff line number Diff line
@@ -1681,14 +1681,15 @@ int ext4_fc_record_regions(struct super_block *sb, int ino, 
	if (state->fc_regions_used == state->fc_regions_size) {

	if (state->fc_regions_used == state->fc_regions_size) {

		struct ext4_fc_alloc_region *fc_regions;

		struct ext4_fc_alloc_region *fc_regions;





		state->fc_regions_size +=

			EXT4_FC_REPLAY_REALLOC_INCREMENT;

		fc_regions = krealloc(state->fc_regions,

		fc_regions = krealloc(state->fc_regions,

				      state->fc_regions_size *

				      sizeof(struct ext4_fc_alloc_region) *

				      sizeof(struct ext4_fc_alloc_region),

				      (state->fc_regions_size +

				       EXT4_FC_REPLAY_REALLOC_INCREMENT),

				      GFP_KERNEL);

				      GFP_KERNEL);

		if (!fc_regions)

		if (!fc_regions)

			return -ENOMEM;

			return -ENOMEM;

		state->fc_regions_size +=

			EXT4_FC_REPLAY_REALLOC_INCREMENT;

		state->fc_regions = fc_regions;

		state->fc_regions = fc_regions;

	}

	}

	region = &state->fc_regions[state->fc_regions_used++];

	region = &state->fc_regions[state->fc_regions_used++];