Commit 375b9ff5 authored by Colin Ian King's avatar Colin Ian King Committed by Shuah Khan
Browse files

kselftest: vDSO: Fix accumulation of uninitialized ret when CLOCK_REALTIME is undefined 



In the unlikely case that CLOCK_REALTIME is not defined, variable ret is
not initialized and further accumulation of return values to ret can leave
ret in an undefined state. Fix this by initialized ret to zero and changing
the assignment of ret to an accumulation for the CLOCK_REALTIME case.

Fixes: 03f55c79 ("kselftest: Extend vDSO selftest to clock_getres")
Signed-off-by: default avatarColin Ian King <colin.i.king@gmail.com>
Reviewed-by: default avatarVincenzo Frascino <vincenzo.frascino@arm.com>
Signed-off-by: default avatarShuah Khan <skhan@linuxfoundation.org>
parent 17cb2f17

tools/testing/selftests/vDSO/vdso_test_clock_getres.c

+2 −2
Original line number Diff line number Diff line
@@ -84,12 +84,12 @@ static inline int vdso_test_clock(unsigned int clock_id) 


int main(int argc, char **argv)

{

	int ret;

	int ret = 0;



#if _POSIX_TIMERS > 0



#ifdef CLOCK_REALTIME

	ret = vdso_test_clock(CLOCK_REALTIME);

	ret += vdso_test_clock(CLOCK_REALTIME);

#endif



#ifdef CLOCK_BOOTTIME