Commit 3ca2385a authored by Bart Van Assche's avatar Bart Van Assche Committed by Martin K. Petersen
Browse files

scsi: ps3rom: Call scsi_done() directly 

Conditional statements are faster than indirect calls. Hence call
scsi_done() directly.

Link: https://lore.kernel.org/r/20211007202923.2174984-63-bvanassche@acm.org


Signed-off-by: default avatarBart Van Assche <bvanassche@acm.org>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent 7bc195c7

drivers/scsi/ps3rom.c

+2 −3
Original line number Diff line number Diff line
@@ -209,7 +209,6 @@ static int ps3rom_queuecommand_lck(struct scsi_cmnd *cmd, 
	int res;



	priv->curr_cmd = cmd;

	cmd->scsi_done = done;



	opcode = cmd->cmnd[0];

	/*
@@ -237,7 +236,7 @@ static int ps3rom_queuecommand_lck(struct scsi_cmnd *cmd, 
		scsi_build_sense(cmd, 0, ILLEGAL_REQUEST, 0, 0);

		cmd->result = res;

		priv->curr_cmd = NULL;

		cmd->scsi_done(cmd);

		scsi_done(cmd);

	}



	return 0;
@@ -321,7 +320,7 @@ static irqreturn_t ps3rom_interrupt(int irq, void *data) 


done:

	priv->curr_cmd = NULL;

	cmd->scsi_done(cmd);

	scsi_done(cmd);

	return IRQ_HANDLED;

}