Commit 3d34b180 authored by Saurav Girepunje's avatar Saurav Girepunje Committed by Greg Kroah-Hartman
Browse files

staging: r8188eu: core: remove the goto from rtw_IOL_accquire_xmit_frame 



Remove the goto statement from rtw_IOL_accquire_xmit_frame(). In this
function goto can be replace by return statement. As on goto label
exit, function only return it is not performing any cleanup. Avoiding
goto will improve the function readability.

Remove the assignment of NULL to local variable xmit_frame just before
return of function. As function return, local variable will be not
available on memory. So assigning a NULL value to local variable just
before function return does not required.

Signed-off-by: default avatarSaurav Girepunje <saurav.girepunje@gmail.com>
Link: https://lore.kernel.org/r/YXd8QdhiNX3B1nqe@Sauravs-MacBook-Air.local


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b6f8bd68

drivers/staging/r8188eu/core/rtw_iol.c

+3 −4
Original line number Diff line number Diff line
@@ -13,15 +13,14 @@ struct xmit_frame *rtw_IOL_accquire_xmit_frame(struct adapter *adapter) 
	xmit_frame = rtw_alloc_xmitframe(pxmitpriv);

	if (!xmit_frame) {

		DBG_88E("%s rtw_alloc_xmitframe return null\n", __func__);

		goto exit;

		return NULL;

	}



	xmitbuf = rtw_alloc_xmitbuf(pxmitpriv);

	if (!xmitbuf) {

		DBG_88E("%s rtw_alloc_xmitbuf return null\n", __func__);

		rtw_free_xmitframe(pxmitpriv, xmit_frame);

		xmit_frame = NULL;

		goto exit;

		return NULL;

	}



	xmit_frame->frame_tag = MGNT_FRAMETAG;
@@ -35,7 +34,7 @@ struct xmit_frame *rtw_IOL_accquire_xmit_frame(struct adapter *adapter) 
	pattrib->subtype = WIFI_BEACON;

	pattrib->pktlen = 0;

	pattrib->last_txcmdsz = 0;

exit:



	return xmit_frame;

}