Commit 447e5602 authored by Thomas Weißschuh's avatar Thomas Weißschuh Committed by Willy Tarreau
Browse files

selftests/nolibc: avoid buffer underrun in space printing 



If the test description is longer than the status alignment the
parameter 'n' to putcharn() would lead to a signed underflow that then
gets converted to a very large unsigned value.
This in turn leads out-of-bound writes in memset() crashing the
application.

The failure case of EXPECT_PTRER() used in "mmap_bad" exhibits this
exact behavior.

Fixes: 29f5540b ("selftests/nolibc: add EXPECT_PTREQ, EXPECT_PTRNE and EXPECT_PTRER")
Signed-off-by: default avatarThomas Weißschuh <linux@weissschuh.net>
Signed-off-by: default avatarWilly Tarreau <w@1wt.eu>
parent 4893c22e

tools/testing/selftests/nolibc/nolibc-test.c

+2 −1
Original line number Diff line number Diff line
@@ -151,6 +151,7 @@ static void result(int llen, enum RESULT r) 
	else

		msg = "[FAIL]";



	if (llen < 64)

		putcharn(' ', 64 - llen);

	puts(msg);

}