Commit 45733d28 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev: Remove FBINFO_DEFAULT from devm_kzalloc()'ed structs 



The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by devm_kzalloc(). So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-5-tzimmermann@suse.de
parent a0331a4b

drivers/video/fbdev/pxafb.c

+0 −1
Original line number Diff line number Diff line
@@ -1826,7 +1826,6 @@ static struct pxafb_info *pxafb_init_fbinfo(struct device *dev, 
	fbi->fb.var.vmode	= FB_VMODE_NONINTERLACED;



	fbi->fb.fbops		= &pxafb_ops;

	fbi->fb.flags		= FBINFO_DEFAULT;

	fbi->fb.node		= -1;



	addr = fbi;

drivers/video/fbdev/sa1100fb.c

+0 −1
Original line number Diff line number Diff line
@@ -1089,7 +1089,6 @@ static struct sa1100fb_info *sa1100fb_init_fbinfo(struct device *dev) 
	fbi->fb.var.vmode	= FB_VMODE_NONINTERLACED;



	fbi->fb.fbops		= &sa1100fb_ops;

	fbi->fb.flags		= FBINFO_DEFAULT;

	fbi->fb.monspecs	= monspecs;

	fbi->fb.pseudo_palette	= fbi->pseudo_palette;

drivers/video/fbdev/wm8505fb.c

+1 −2
Original line number Diff line number Diff line
@@ -285,8 +285,7 @@ static int wm8505fb_probe(struct platform_device *pdev) 
	fbi->fb.fix.accel	= FB_ACCEL_NONE;



	fbi->fb.fbops		= &wm8505fb_ops;

	fbi->fb.flags		= FBINFO_DEFAULT

				| FBINFO_HWACCEL_COPYAREA

	fbi->fb.flags		= FBINFO_HWACCEL_COPYAREA

				| FBINFO_HWACCEL_FILLRECT

				| FBINFO_HWACCEL_XPAN

				| FBINFO_HWACCEL_YPAN

drivers/video/fbdev/xilinxfb.c

+0 −1
Original line number Diff line number Diff line
@@ -324,7 +324,6 @@ static int xilinxfb_assign(struct platform_device *pdev, 
	drvdata->info.fix.line_length = pdata->xvirt * BYTES_PER_PIXEL;



	drvdata->info.pseudo_palette = drvdata->pseudo_palette;

	drvdata->info.flags = FBINFO_DEFAULT;

	drvdata->info.var = xilinx_fb_var;

	drvdata->info.var.height = pdata->screen_height_mm;

	drvdata->info.var.width = pdata->screen_width_mm;