Commit a0331a4b authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev: Remove FBINFO_DEFAULT from kzalloc()'ed structs 



The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by kzalloc(). So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Cc: Russell King <linux@armlinux.org.uk>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-4-tzimmermann@suse.de
parent 6304da8a

drivers/video/fbdev/controlfb.c

+1 −1
Original line number Diff line number Diff line
@@ -775,7 +775,7 @@ static void __init control_init_info(struct fb_info *info, struct fb_info_contro 
	info->par = &p->par;

	info->fbops = &controlfb_ops;

	info->pseudo_palette = p->pseudo_palette;

        info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

	info->flags = FBINFO_HWACCEL_YPAN;

	info->screen_base = p->frame_buffer + CTRLFB_OFF;



	fb_alloc_cmap(&info->cmap, 256, 0);

drivers/video/fbdev/cyber2000fb.c

+1 −1
Original line number Diff line number Diff line
@@ -1459,7 +1459,7 @@ static struct cfb_info *cyberpro_alloc_fb_info(unsigned int id, char *name) 
	cfb->fb.var.accel_flags	= FB_ACCELF_TEXT;



	cfb->fb.fbops		= &cyber2000fb_ops;

	cfb->fb.flags		= FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

	cfb->fb.flags		= FBINFO_HWACCEL_YPAN;

	cfb->fb.pseudo_palette	= cfb->pseudo_palette;



	spin_lock_init(&cfb->reg_b0_lock);

drivers/video/fbdev/valkyriefb.c

+0 −1
Original line number Diff line number Diff line
@@ -535,7 +535,6 @@ static int __init valkyrie_init_info(struct fb_info *info, 
{

	info->fbops = &valkyriefb_ops;

	info->screen_base = p->frame_buffer + 0x1000;

	info->flags = FBINFO_DEFAULT;

	info->pseudo_palette = p->pseudo_palette;

	info->par = &p->par;

	return fb_alloc_cmap(&info->cmap, 256, 0);

drivers/video/fbdev/vermilion/vermilion.c

+1 −1
Original line number Diff line number Diff line
@@ -477,7 +477,7 @@ static int vml_pci_probe(struct pci_dev *dev, const struct pci_device_id *id) 
	}



	info = &vinfo->info;

	info->flags = FBINFO_DEFAULT | FBINFO_PARTIAL_PAN_OK;

	info->flags = FBINFO_PARTIAL_PAN_OK;



	err = vmlfb_enable_mmio(par);

	if (err)

drivers/video/fbdev/vt8500lcdfb.c

+1 −2
Original line number Diff line number Diff line
@@ -300,8 +300,7 @@ static int vt8500lcd_probe(struct platform_device *pdev) 
	fbi->fb.var.vmode	= FB_VMODE_NONINTERLACED;



	fbi->fb.fbops		= &vt8500lcd_ops;

	fbi->fb.flags		= FBINFO_DEFAULT

				| FBINFO_HWACCEL_COPYAREA

	fbi->fb.flags		= FBINFO_HWACCEL_COPYAREA

				| FBINFO_HWACCEL_FILLRECT

				| FBINFO_HWACCEL_YPAN

				| FBINFO_VIRTFB