Commit 4582e783 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Pavel Machek
Browse files

leds: sgm3140: Simplify with dev_err_probe() 



Common pattern of handling deferred probe can be simplified with
dev_err_probe().  Less code and also it prints the error value.

Signed-off-by: default avatarKrzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: default avatarPavel Machek <pavel@ucw.cz>
parent 7e8da605

drivers/leds/leds-sgm3140.c

+9 −18
Original line number Diff line number Diff line
@@ -195,30 +195,21 @@ static int sgm3140_probe(struct platform_device *pdev) 


	priv->flash_gpio = devm_gpiod_get(&pdev->dev, "flash", GPIOD_OUT_LOW);

	ret = PTR_ERR_OR_ZERO(priv->flash_gpio);

	if (ret) {

		if (ret != -EPROBE_DEFER)

			dev_err(&pdev->dev,

				"Failed to request flash gpio: %d\n", ret);

		return ret;

	}

	if (ret)

		return dev_err_probe(&pdev->dev, ret,

				     "Failed to request flash gpio\n");



	priv->enable_gpio = devm_gpiod_get(&pdev->dev, "enable", GPIOD_OUT_LOW);

	ret = PTR_ERR_OR_ZERO(priv->enable_gpio);

	if (ret) {

		if (ret != -EPROBE_DEFER)

			dev_err(&pdev->dev,

				"Failed to request enable gpio: %d\n", ret);

		return ret;

	}

	if (ret)

		return dev_err_probe(&pdev->dev, ret,

				     "Failed to request enable gpio\n");



	priv->vin_regulator = devm_regulator_get(&pdev->dev, "vin");

	ret = PTR_ERR_OR_ZERO(priv->vin_regulator);

	if (ret) {

		if (ret != -EPROBE_DEFER)

			dev_err(&pdev->dev,

				"Failed to request regulator: %d\n", ret);

		return ret;

	}

	if (ret)

		return dev_err_probe(&pdev->dev, ret,

				     "Failed to request regulator\n");



	child_node = fwnode_get_next_available_child_node(pdev->dev.fwnode,

							  NULL);