Commit 4a850f8d authored by Sean Wang's avatar Sean Wang Committed by Felix Fietkau
Browse files

mt76: mt7663u: fix memory leak in set key 



Fix memory leak in set key.

Fixes: eb99cc95 ("mt76: mt7615: introduce mt7663u support")
Signed-off-by: default avatarSean Wang <sean.wang@mediatek.com>
Acked-by: default avatarLorenzo Bianconi <lorenzo@kernel.org>
Signed-off-by: default avatarFelix Fietkau <nbd@nbd.name>
parent d71d67a7

drivers/net/wireless/mediatek/mt76/mt7615/usb.c

+14 −7
Original line number Diff line number Diff line
@@ -167,12 +167,16 @@ __mt7663u_mac_set_key(struct mt7615_dev *dev, 


	lockdep_assert_held(&dev->mt76.mutex);



	if (!sta)

		return -EINVAL;

	if (!sta) {

		err = -EINVAL;

		goto out;

	}



	cipher = mt7615_mac_get_cipher(key->cipher);

	if (cipher == MT_CIPHER_NONE)

		return -EOPNOTSUPP;

	if (cipher == MT_CIPHER_NONE) {

		err = -EOPNOTSUPP;

		goto out;

	}



	wcid = &wd->sta->wcid;
@@ -180,19 +184,22 @@ __mt7663u_mac_set_key(struct mt7615_dev *dev, 
	err = mt7615_mac_wtbl_update_key(dev, wcid, key->key, key->keylen,

					 cipher, key->cmd);

	if (err < 0)

		return err;

		goto out;



	err = mt7615_mac_wtbl_update_pk(dev, wcid, cipher, key->keyidx,

					key->cmd);

	if (err < 0)

		return err;

		goto out;



	if (key->cmd == SET_KEY)

		wcid->cipher |= BIT(cipher);

	else

		wcid->cipher &= ~BIT(cipher);



	return 0;

out:

	kfree(key->key);



	return err;

}



void mt7663u_wtbl_work(struct work_struct *work)