Commit 7abf253a authored by xingtong.wu's avatar xingtong.wu Committed by Hans de Goede
Browse files

platform/x86/siemens: simatic-ipc-batt: fix logical error for BX-59A 



The variable "priv.devmode" is missing from if statement that leads
to a logical error. Add the missing variable to the if condition.

Fixes: c56beff2 ("platform/x86/siemens: simatic-ipc-batt: add support for module BX-59A")
Reported-by: default avatarkernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202308010001.BGYCSQrl-lkp@intel.com/


Reviewed-by: default avatarIlpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: default avatarxingtong.wu <xingtong.wu@siemens.com>
Link: https://lore.kernel.org/r/20430802173844.2483-1-xingtong_wu@163.com


Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
parent b01c1e02

drivers/platform/x86/siemens/simatic-ipc-batt.c

+2 −1
Original line number Diff line number Diff line
@@ -194,7 +194,8 @@ int simatic_ipc_batt_probe(struct platform_device *pdev, struct gpiod_lookup_tab 


	if (table->table[2].key) {

		flags = GPIOD_OUT_HIGH;

		if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A || SIMATIC_IPC_DEVICE_BX_59A)

		if (priv.devmode == SIMATIC_IPC_DEVICE_BX_21A ||

		    priv.devmode == SIMATIC_IPC_DEVICE_BX_59A)

			flags = GPIOD_OUT_LOW;

		priv.gpios[2] = devm_gpiod_get_index(dev, "CMOSBattery meter", 2, flags);

		if (IS_ERR(priv.gpios[2])) {