Commit 81f776b6 authored by Anthony Koo's avatar Anthony Koo Committed by Alex Deucher
Browse files

drm/amd/display: Add support for manual DMUB FAMS trigger 



- Add is_drr parameter to indicate DRR is enabled on
the panel to determine whether SubVP MCLK switch
logic should be enabled

- Add DRR manual trigger in FW (instead of driver)
because manual trigger programming triggers DRR
update pending and can block SubVP MCLK switches
from taking place

Acked-by: default avatarAlex Hung <alex.hung@amd.com>
Signed-off-by: default avatarAnthony Koo <Anthony.Koo@amd.com>
Tested-by: default avatarDaniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 1f5dcb73

drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h

+8 −1
Original line number Diff line number Diff line
@@ -976,7 +976,8 @@ struct dmub_cmd_fw_assisted_mclk_switch_pipe_data_v2 { 
			uint16_t vtotal;

			uint8_t main_pipe_index;

			uint8_t phantom_pipe_index;

			uint8_t padding[2];

			uint8_t is_drr;

			uint8_t padding;

		} subvp_data;



		struct {
@@ -1579,6 +1580,12 @@ enum dmub_cmd_fams_type { 
	DMUB_CMD__FAMS_SETUP_FW_CTRL	= 0,

	DMUB_CMD__FAMS_DRR_UPDATE		= 1,

	DMUB_CMD__HANDLE_SUBVP_CMD	= 2, // specifically for SubVP cmd

	/**

	 * For SubVP set manual trigger in FW because it

	 * triggers DRR_UPDATE_PENDING which SubVP relies

	 * on (for any SubVP cases that use a DRR display)

	 */

	DMUB_CMD__FAMS_SET_MANUAL_TRIGGER = 3,

};



/**