Unverified Commit 8e1ae6f6 authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Mark Brown
Browse files

ASoC: Intel: avs: simplify S3 resume flows 



The same code was directly copied from the skylake driver where it was
already questionable. Remove and simplify the flow.

Tested-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: default avatarRanjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: default avatarRander Wang <rander.wang@intel.com>
Reviewed-by: default avatarBard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: default avatarPéter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: default avatarCezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20221017204946.207986-3-pierre-louis.bossart@linux.intel.com


Signed-off-by: default avatarMark Brown <broonie@kernel.org>
parent fac33cb5

sound/soc/intel/avs/core.c

+0 −11
Original line number Diff line number Diff line
@@ -580,7 +580,6 @@ static int __maybe_unused avs_suspend_common(struct avs_dev *adev) 
static int __maybe_unused avs_resume_common(struct avs_dev *adev, bool purge)

{

	struct hdac_bus *bus = &adev->base.core;

	struct hdac_ext_link *hlink;

	int ret;



	snd_hdac_display_power(bus, HDA_CODEC_IDX_CONTROLLER, true);
@@ -595,16 +594,6 @@ static int __maybe_unused avs_resume_common(struct avs_dev *adev, bool purge) 
		return ret;

	}



	/* turn off the links that were off before suspend */

	list_for_each_entry(hlink, &bus->hlink_list, list) {

		if (!hlink->ref_count)

			snd_hdac_ext_bus_link_power_down(hlink);

	}



	/* check dma status and clean up CORB/RIRB buffers */

	if (!bus->cmd_dma_state)

		snd_hdac_bus_stop_cmd_io(bus);



	return 0;

}