Commit 8f2e4527 authored by Dan Carpenter's avatar Dan Carpenter Committed by Mauro Carvalho Chehab
Browse files

media: au0828: fix a NULL vs IS_ERR() check 



The media_device_usb_allocate() function returns error pointers when
it's enabled and something goes wrong.  It can return NULL as well, but
only if CONFIG_MEDIA_CONTROLLER is disabled so that doesn't apply here.

Fixes: 812658d8 ("media: change au0828 to use Media Device Allocator API")
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 1fcbeeb5

drivers/media/usb/au0828/au0828-core.c

+2 −2
Original line number Diff line number Diff line
@@ -199,8 +199,8 @@ static int au0828_media_device_init(struct au0828_dev *dev, 
	struct media_device *mdev;



	mdev = media_device_usb_allocate(udev, KBUILD_MODNAME, THIS_MODULE);

	if (!mdev)

		return -ENOMEM;

	if (IS_ERR(mdev))

		return PTR_ERR(mdev);



	dev->media_dev = mdev;

#endif