Commit 9326f76f authored by Josef Bacik's avatar Josef Bacik Committed by David Sterba
Browse files

btrfs: hold a ref on the root in resolve_indirect_ref 



We're looking up a random root, we need to hold a ref on it while we're
using it.

Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarJosef Bacik <josef@toxicpanda.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent af01d2e5

fs/btrfs/backref.c

+9 −1
Original line number Diff line number Diff line
@@ -524,7 +524,13 @@ static int resolve_indirect_ref(struct btrfs_fs_info *fs_info, 
	if (IS_ERR(root)) {

		srcu_read_unlock(&fs_info->subvol_srcu, index);

		ret = PTR_ERR(root);

		goto out;

		goto out_free;

	}



	if (!btrfs_grab_fs_root(root)) {

		srcu_read_unlock(&fs_info->subvol_srcu, index);

		ret = -ENOENT;

		goto out_free;

	}



	if (btrfs_is_testing(fs_info)) {
@@ -577,6 +583,8 @@ static int resolve_indirect_ref(struct btrfs_fs_info *fs_info, 
	ret = add_all_parents(root, path, parents, ref, level, time_seq,

			      extent_item_pos, total_refs, ignore_offset);

out:

	btrfs_put_fs_root(root);

out_free:

	path->lowest_level = 0;

	btrfs_release_path(path);

	return ret;