Commit ae27b2f9 authored by Todd Poynor's avatar Todd Poynor Committed by Greg Kroah-Hartman
Browse files

staging: gasket: fix class create bug handling 



class_create() never returns NULL, and this driver should never return
PTR_ERR(NULL) anyway.

Reported-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarZhongze Hu <frankhu@chromium.org>
Signed-off-by: default avatarTodd Poynor <toddpoynor@google.com>
Reviewed-by: default avatarDmitry Torokhov <dtor@chromium.org>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent b6fdbbb7

drivers/staging/gasket/gasket_core.c

+1 −1
Original line number Diff line number Diff line
@@ -321,7 +321,7 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc) 
	internal->class =

		class_create(driver_desc->module, driver_desc->name);



	if (IS_ERR_OR_NULL(internal->class)) {

	if (IS_ERR(internal->class)) {

		gasket_nodev_error("Cannot register %s class [ret=%ld]",

				   driver_desc->name, PTR_ERR(internal->class));

		ret = PTR_ERR(internal->class);