Commit ae5a16c8 authored by Alexandre Torgue's avatar Alexandre Torgue Committed by Rob Herring
Browse files

scripts: dtc: only show unique unit address warning for enabled nodes 



In some cases an hardware peripheral can be used for two exclusive usages.
For example, on STM32MP15 we have the same peripheral for I2S and SPI. We
have dedicated driver for each usage and so a dedicated device node in
devicetree.
To avoid to get useless warnings running "make W=1 dtbs", this patch adds
the "-Wunique_unit_address_if_enabled" flag for a make with W=1. In this
case we will detect a duplicate address only if both devices are
enabled in the devicetree, which is a real error case.

Signed-off-by: default avatarAlexandre Torgue <alexandre.torgue@foss.st.com>
Link: https://lore.kernel.org/r/20221021084447.5550-1-alexandre.torgue@foss.st.com


[robh: Refactor options and keep 'unique_unit_address' for W=2]
Signed-off-by: default avatarRob Herring <robh@kernel.org>
parent 33ce453c

scripts/Makefile.lib

+8 −4
Original line number Diff line number Diff line
@@ -334,7 +334,8 @@ quiet_cmd_gzip = GZIP $@ 
# DTC

# ---------------------------------------------------------------------------

DTC ?= $(objtree)/scripts/dtc/dtc

DTC_FLAGS += -Wno-interrupt_provider

DTC_FLAGS += -Wno-interrupt_provider \

	-Wno-unique_unit_address



# Disable noisy checks by default

ifeq ($(findstring 1,$(KBUILD_EXTRA_WARN)),)
@@ -342,14 +343,17 @@ DTC_FLAGS += -Wno-unit_address_vs_reg \ 
	-Wno-avoid_unnecessary_addr_size \

	-Wno-alias_paths \

	-Wno-graph_child_address \

	-Wno-simple_bus_reg \

	-Wno-unique_unit_address

	-Wno-simple_bus_reg

else

DTC_FLAGS += \

        -Wunique_unit_address_if_enabled

endif



ifneq ($(findstring 2,$(KBUILD_EXTRA_WARN)),)

DTC_FLAGS += -Wnode_name_chars_strict \

	-Wproperty_name_chars_strict \

	-Winterrupt_provider

	-Winterrupt_provider \

	-Wunique_unit_address

endif



DTC_FLAGS += $(DTC_FLAGS_$(basetarget))