Commit b2065fb2 authored by Vijendar Mukunda's avatar Vijendar Mukunda Committed by Alex Deucher
Browse files

drm/amdgpu: fix i2s_pdata out of bound array access 



Fixed following Smatch static checker warning:

    drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:393 acp_hw_init()
    error: buffer overflow 'i2s_pdata' 3 <= 3
    drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c:396 acp_hw_init()
    error: buffer overflow 'i2s_pdata' 3 <= 3

Fixes: 4c33e517 ("drm/amdgpu: create I2S platform devices for Jadeite platform")
Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarVijendar Mukunda <Vijendar.Mukunda@amd.com>
Acked-by: default avatarAlex Deucher <alexander.deucher@amd.com>
Signed-off-by: default avatarAlex Deucher <alexander.deucher@amd.com>
parent 0dc204bc

drivers/gpu/drm/amd/amdgpu/amdgpu_acp.c

+0 −8
Original line number Diff line number Diff line
@@ -390,14 +390,6 @@ static int acp_hw_init(void *handle) 
		i2s_pdata[2].i2s_reg_comp1 = ACP_BT_COMP1_REG_OFFSET;

		i2s_pdata[2].i2s_reg_comp2 = ACP_BT_COMP2_REG_OFFSET;



		i2s_pdata[3].quirks = DW_I2S_QUIRK_COMP_REG_OFFSET;

		switch (adev->asic_type) {

		case CHIP_STONEY:

			i2s_pdata[3].quirks |= DW_I2S_QUIRK_16BIT_IDX_OVERRIDE;

			break;

		default:

			break;

		}

		adev->acp.acp_res[0].name = "acp2x_dma";

		adev->acp.acp_res[0].flags = IORESOURCE_MEM;

		adev->acp.acp_res[0].start = acp_base;