Commit b3e148d7 authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

fbdev: Remove FBINFO_DEFAULT from framebuffer_alloc()'ed structs 



The flag FBINFO_DEFAULT is 0 and has no effect, as struct fbinfo.flags
has been allocated to zero by framebuffer_alloc(). So do not set it.

Flags should signal differences from the default values. After cleaning
up all occurrences of FBINFO_DEFAULT, the token will be removed.

v4:
	* clarify commit message (Geert, Dan)
v2:
	* fix commit message (Miguel)

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Cc: Helge Deller <deller@gmx.de>
Cc: Nicolas Ferre <nicolas.ferre@microchip.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Ferenc Bakonyi <fero@drama.obuda.kando.hu>
Cc: "K. Y. Srinivasan" <kys@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Cc: Wei Liu <wei.liu@kernel.org>
Cc: Dexuan Cui <decui@microsoft.com>
Cc: Antonino Daplas <adaplas@gmail.com>
Cc: Maik Broemme <mbroemme@libmpq.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Cc: Steve Glendinning <steve.glendinning@shawell.net>
Cc: Bernie Thompson <bernie@plugable.com>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230715185343.7193-6-tzimmermann@suse.de
parent 45733d28

drivers/video/fbdev/amifb.c

+2 −3
Original line number Diff line number Diff line
@@ -2427,7 +2427,7 @@ static int amifb_set_par(struct fb_info *info) 
		info->fix.ywrapstep = 1;

		info->fix.xpanstep = 0;

		info->fix.ypanstep = 0;

		info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YWRAP |

		info->flags = FBINFO_HWACCEL_YWRAP |

			FBINFO_READS_FAST; /* override SCROLL_REDRAW */

	} else {

		info->fix.ywrapstep = 0;
@@ -2436,7 +2436,7 @@ static int amifb_set_par(struct fb_info *info) 
		else

			info->fix.xpanstep = 16 << maxfmode;

		info->fix.ypanstep = 1;

		info->flags = FBINFO_DEFAULT | FBINFO_HWACCEL_YPAN;

		info->flags = FBINFO_HWACCEL_YPAN;

	}

	return 0;

}
@@ -3660,7 +3660,6 @@ static int __init amifb_probe(struct platform_device *pdev) 
	}



	info->fbops = &amifb_ops;

	info->flags = FBINFO_DEFAULT;

	info->device = &pdev->dev;



	if (!fb_find_mode(&info->var, info, mode_option, ami_modedb,

drivers/video/fbdev/asiliantfb.c

+0 −1
Original line number Diff line number Diff line
@@ -516,7 +516,6 @@ static int init_asiliant(struct fb_info *p, unsigned long addr) 
	p->fix.smem_start	= addr;

	p->var			= asiliantfb_var;

	p->fbops		= &asiliantfb_ops;

	p->flags		= FBINFO_DEFAULT;



	err = fb_alloc_cmap(&p->cmap, 256, 0);

	if (err) {

drivers/video/fbdev/atmel_lcdfb.c

+1 −1
Original line number Diff line number Diff line
@@ -1059,7 +1059,7 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) 
	if (IS_ERR(sinfo->reg_lcd))

		sinfo->reg_lcd = NULL;



	info->flags = FBINFO_DEFAULT | FBINFO_PARTIAL_PAN_OK |

	info->flags = FBINFO_PARTIAL_PAN_OK |

		      FBINFO_HWACCEL_YPAN;

	info->pseudo_palette = sinfo->pseudo_palette;

	info->fbops = &atmel_lcdfb_ops;

drivers/video/fbdev/aty/atyfb_base.c

+1 −2
Original line number Diff line number Diff line
@@ -2637,8 +2637,7 @@ static int aty_init(struct fb_info *info) 


	info->fbops = &atyfb_ops;

	info->pseudo_palette = par->pseudo_palette;

	info->flags = FBINFO_DEFAULT           |

		      FBINFO_HWACCEL_IMAGEBLIT |

	info->flags = FBINFO_HWACCEL_IMAGEBLIT |

		      FBINFO_HWACCEL_FILLRECT  |

		      FBINFO_HWACCEL_COPYAREA  |

		      FBINFO_HWACCEL_YPAN      |

drivers/video/fbdev/aty/radeon_base.c

+1 −2
Original line number Diff line number Diff line
@@ -1972,8 +1972,7 @@ static int radeon_set_fbinfo(struct radeonfb_info *rinfo) 


	info->par = rinfo;

	info->pseudo_palette = rinfo->pseudo_palette;

	info->flags = FBINFO_DEFAULT

		    | FBINFO_HWACCEL_COPYAREA

	info->flags = FBINFO_HWACCEL_COPYAREA

		    | FBINFO_HWACCEL_FILLRECT

		    | FBINFO_HWACCEL_XPAN

		    | FBINFO_HWACCEL_YPAN;