Commit b4dc97ab authored by Yang Yingliang's avatar Yang Yingliang Committed by Vinod Koul
Browse files

phy: Sparx5 Eth SerDes: Fix return value check in sparx5_serdes_probe() 



In case of error, the function devm_ioremap() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value
check should be replaced with NULL test.

Fixes: 2ff8a1ee ("phy: Add Sparx5 ethernet serdes PHY driver")
Reported-by: default avatarHulk Robot <hulkci@huawei.com>
Signed-off-by: default avatarYang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210909072149.2934047-1-yangyingliang@huawei.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent b475bf0e

drivers/phy/microchip/sparx5_serdes.c

+2 −2
Original line number Diff line number Diff line
@@ -2475,10 +2475,10 @@ static int sparx5_serdes_probe(struct platform_device *pdev) 
		return -EINVAL;

	}

	iomem = devm_ioremap(priv->dev, iores->start, resource_size(iores));

	if (IS_ERR(iomem)) {

	if (!iomem) {

		dev_err(priv->dev, "Unable to get serdes registers: %s\n",

			iores->name);

		return PTR_ERR(iomem);

		return -ENOMEM;

	}

	for (idx = 0; idx < ARRAY_SIZE(sparx5_serdes_iomap); idx++) {

		struct sparx5_serdes_io_resource *iomap = &sparx5_serdes_iomap[idx];