Unverified Commit bbb6f93f authored by Javier Martinez Canillas's avatar Javier Martinez Canillas
Browse files

drm/bridge: ti-sn65dsi86: Use dev_err_probe() to avoid polluting the log 



If devm_drm_of_get_bridge() can't find the connected bridge, it returns an
ERR_PTR(-EPROBE_DEFER) to indicate that the probe should be deferred.

But this path also prints an error message, which pollutes the kernel log
since is printed on every probe deferral, i.e:

  $ dmesg | grep "failed to create panel bridge" | wc -l
  38

Signed-off-by: default avatarJavier Martinez Canillas <javierm@redhat.com>
Reviewed-by: default avatarNeil Armstrong <narmstrong@baylibre.com>
Reviewed-by: default avatarAndrzej Hajda <andrzej.hajda@intel.com>
Reviewed-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20220722074755.660258-1-javierm@redhat.com
parent eaa225b6

drivers/gpu/drm/bridge/ti-sn65dsi86.c

+3 −4
Original line number Diff line number Diff line
@@ -1206,10 +1206,9 @@ static int ti_sn_bridge_probe(struct auxiliary_device *adev, 
	int ret;



	pdata->next_bridge = devm_drm_of_get_bridge(pdata->dev, np, 1, 0);

	if (IS_ERR(pdata->next_bridge)) {

		DRM_ERROR("failed to create panel bridge\n");

		return PTR_ERR(pdata->next_bridge);

	}

	if (IS_ERR(pdata->next_bridge))

		return dev_err_probe(pdata->dev, PTR_ERR(pdata->next_bridge),

				     "failed to create panel bridge\n");



	ti_sn_bridge_parse_lanes(pdata, np);