Commit bbfa509d authored by Uwe Kleine-König's avatar Uwe Kleine-König Committed by Michael Ellerman
Browse files

powerpc/ep8248e: Mark driver as non removable 



Instead of resorting to BUG() ensure that the driver isn't unbound by
suppressing its bind and unbind sysfs attributes. As the driver is
built-in there is no way to remove a device once bound.

As a nice side effect this allows to drop the remove function.

Signed-off-by: default avatarUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: default avatarMichael Ellerman <mpe@ellerman.id.au>
Link: https://msgid.link/20230726081442.461026-1-u.kleine-koenig@pengutronix.de
parent 54f30b83

arch/powerpc/platforms/82xx/ep8248e.c

+1 −7
Original line number Diff line number Diff line
@@ -141,12 +141,6 @@ static int ep8248e_mdio_probe(struct platform_device *ofdev) 
	return ret;

}



static int ep8248e_mdio_remove(struct platform_device *ofdev)

{

	BUG();

	return 0;

}



static const struct of_device_id ep8248e_mdio_match[] = {

	{

		.compatible = "fsl,ep8248e-mdio-bitbang",
@@ -158,9 +152,9 @@ static struct platform_driver ep8248e_mdio_driver = { 
	.driver = {

		.name = "ep8248e-mdio-bitbang",

		.of_match_table = ep8248e_mdio_match,

		.suppress_bind_attrs = true,

	},

	.probe = ep8248e_mdio_probe,

	.remove = ep8248e_mdio_remove,

};



struct cpm_pin {