Commit ca866920 authored by Osama Muhammad's avatar Osama Muhammad Committed by Guenter Roeck
Browse files

hwmon: (pmbus/ucd9000) Drop unnecessary error check for debugfs_create_dir 

This patch removes the error checking for debugfs_create_dir
in ucd9000.c. This is because the debugfs_create_dir() does not
return NULL but an ERR_PTR after an error.
The DebugFS kernel API is developed in a way that the
caller can safely ignore the errors that occur during
the creation of DebugFS nodes.The debugfs Api handles
it gracefully. The check is unnecessary.

Link to the comment above debugfs_create_dir:
https://elixir.bootlin.com/linux/latest/source/fs/debugfs/inode.c#L565



Signed-off-by: default avatarOsama Muhammad <osmtendev@gmail.com>
Link: https://lore.kernel.org/r/20230526154906.6370-1-osmtendev@gmail.com


Signed-off-by: default avatarGuenter Roeck <linux@roeck-us.net>
parent 153c9a02

drivers/hwmon/pmbus/ucd9000.c

+0 −2
Original line number Diff line number Diff line
@@ -512,8 +512,6 @@ static int ucd9000_init_debugfs(struct i2c_client *client, 
		return -ENOENT;



	data->debugfs = debugfs_create_dir(client->name, debugfs);

	if (!data->debugfs)

		return -ENOENT;



	/*

	 * Of the chips this driver supports, only the UCD9090, UCD90160,