Skip to content
Commit ce389573 authored by Alex Williamson's avatar Alex Williamson
Browse files

vfio/ap/ccw/samples: Fix device_register() unwind path



We always need to call put_device() if device_register() fails.
All vfio drivers calling device_register() include a similar unwind
stack via gotos, therefore split device_unregister() into its
device_del() and put_device() components in the unwind path, and
add a goto target to handle only the put_device() requirement.

Reported-by: default avatarRuan Jinjie <ruanjinjie@huawei.com>
Link: https://lore.kernel.org/all/20221118032827.3725190-1-ruanjinjie@huawei.com


Fixes: d61fc96f ("sample: vfio mdev display - host device")
Fixes: 9d1a546c ("docs: Sample driver to demonstrate how to use Mediated device framework.")
Fixes: a5e6e650 ("sample: vfio bochs vbe display (host device for bochs-drm)")
Fixes: 9e6f07cd ("vfio/ccw: create a parent struct")
Fixes: 36360658 ("s390: vfio_ap: link the vfio_ap devices to the vfio_ap bus subsystem")
Cc: Tony Krowiak <akrowiak@linux.ibm.com>
Cc: Halil Pasic <pasic@linux.ibm.com>
Cc: Jason Herne <jjherne@linux.ibm.com>
Cc: Kirti Wankhede <kwankhede@nvidia.com>
Reviewed-by: default avatarKevin Tian <kevin.tian@intel.com>
Reviewed-by: default avatarEric Farman <farman@linux.ibm.com>
Reviewed-by: default avatarTony Krowiak <akrowiak@linux.ibm.com>
Reviewed-by: default avatarJason J. Herne <jjherne@linux.ibm.com>
Link: https://lore.kernel.org/r/166999942139.645727.12439756512449846442.stgit@omen


Signed-off-by: default avatarAlex Williamson <alex.williamson@redhat.com>
parent e2d55709
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment