Commit d8018ec1 authored Aug 07, 2020 by Daniel W. S. Almeida Committed by Mauro Carvalho Chehab Aug 29, 2020

media: pci: saa7164-vbi.c: replace if (cond) BUG() with BUG_ON()

Fix the following coccinelle reports:

drivers/media/pci/saa7164/saa7164-vbi.c:707:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

drivers/media/pci/saa7164/saa7164-vbi.c:760:2-5:
WARNING: Use BUG_ON instead of if condition followed by BUG.

Found using - Coccinelle (http://coccinelle.lip6.fr

)

Signed-off-by: Daniel W. S. Almeida <dwlsalmeida@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

parent a1bb5cca

drivers/media/pci/saa7164/saa7164-vbi.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -703,8 +703,7 @@ int saa7164_vbi_register(struct saa7164_port *port)

		dprintk(DBGLVL_VBI, "%s()\n", __func__);

		if (port->type != SAA7164_MPEG_VBI)
		BUG();
		BUG_ON(port->type != SAA7164_MPEG_VBI);

		/* Sanity check that the PCI configuration space is active */
		if (port->hwcfg.BARLocation == 0) {
		@@ -756,8 +755,7 @@ void saa7164_vbi_unregister(struct saa7164_port *port)

		dprintk(DBGLVL_VBI, "%s(port=%d)\n", __func__, port->nr);

		if (port->type != SAA7164_MPEG_VBI)
		BUG();
		BUG_ON(port->type != SAA7164_MPEG_VBI);

		if (port->v4l_device) {
		if (port->v4l_device->minor != -1)