Skip to content
Commit e3158a5e authored by Peilin Ye's avatar Peilin Ye Committed by Mauro Carvalho Chehab
Browse files

media: vivid: Fix global-out-of-bounds read in precalculate_color()



vivid_meta_out_process() is setting `brightness`, `contrast`, `saturation`
and `hue` using tpg_s_*(). This is wrong, since tpg_s_*() do not provide
range checks. Using tpg_s_*() here also makes the control framework
out-of-sync with the actual values. Use v4l2_ctrl_s_ctrl() instead.

This issue has been reported by syzbot as an out-of-bounds read bug in
precalculate_color().

Reported-and-tested-by: default avatar <syzbot+02d9172bf4c43104cd70@syzkaller.appspotmail.com>
Link: https://syzkaller.appspot.com/bug?extid=02d9172bf4c43104cd70



Fixes: 746facd3 ("media: vivid: Add metadata output support")
Suggested-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarPeilin Ye <yepeilin.cs@gmail.com>
Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+huawei@kernel.org>
parent 209d926b
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment