Skip to content
Commit f340ed86 authored by Peter Geis's avatar Peter Geis Committed by Vinod Koul
Browse files

phy: rockchip-inno-usb2: Return zero after otg sync



The otg sync state patch reuses the ret variable, but fails to set it to
zero after use. This leads to a situation when the otg port is in
peripheral mode where the otg phy aborts halfway through setup.  It also
fails to account for a failure to register the extcon notifier. Fix this
by using our own variable and skipping otg sync in case of failure.

Fixes: 8dc60f8d ("phy: rockchip-inno-usb2: Sync initial otg state")
Reported-by: default avatarMarkus Reichl <m.reichl@fivetechno.de>
Reported-by: default avatarMichael Riesch <michael.riesch@wolfvision.net>
Signed-off-by: default avatarPeter Geis <pgwipeout@gmail.com>
Tested-by: default avatarMichael Riesch <michael.riesch@wolfvision.net>
Tested-by: default avatarMarkus Reichl <m.reichl@fivetechno.de>
Reviewed-by: default avatarSamuel Holland <samuel@sholland.org>
Link: https://lore.kernel.org/r/20220902184543.1234835-1-pgwipeout@gmail.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent 766ab0de
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please to comment